Re: BUG #8611: ECPG: unclosed comment "/*"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: alexsav23(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #8611: ECPG: unclosed comment "/*"
Date: 2013-11-22 20:19:10
Message-ID: 24807.1385151550@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Meskes <meskes(at)postgresql(dot)org> writes:
> On Wed, Nov 20, 2013 at 11:18:18AM +0000, alexsav23(at)gmail(dot)com wrote:
>> pre-compiler don't work if we have unclosed comment:

> Right, this comes from ecpg using the same rules for C-style commands for SQL
> code and C code. However, this is not correct, I agree. SQL allows for nested
> comments while C does not. This needs fixing.

I don't see any way to "fix" it --- the best you can do is have a
different set of users complaining, because C and SQL aren't consistent
about this, and it's not obvious which convention should be followed
where.

Perhaps we should just document that you should avoid nested comments
in ecpg source code.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeffrey Walton 2013-11-22 23:26:47 Re: fe-secure.c and SSL/TLS
Previous Message Jeff Janes 2013-11-22 20:04:16 Re: BUG #8612: Truncate did not release disk space