From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
Cc: | "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Zoltan Boszormenyi" <zb(at)cybertec(dot)at>, pgsql-patches(at)postgresql(dot)org, "Hans-Juergen Schoenig" <hs(at)cybertec(dot)at>, "Magnus Hagander" <magnus(at)hagander(dot)net> |
Subject: | Re: float4/float8/int64 passed by value with tsearchfixup |
Date: | 2008-04-18 22:01:24 |
Message-ID: | 24749.1208556084@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
>> Tom Lane wrote:
>>> Specifically, I think what you missed is that on some platforms C
>>> functions pass or return float values differently from similar-sized
>>> integer or pointer values (typically, the float values get passed in
>>> floating-point registers).
> Hum. That's a valid concern for some platforms, Sparc I think?
> But I'm skeptical that it would hit such a wide swathe of the build
> farm.
I was wondering about that too, once it became obvious that (almost?)
everything was failing not just some platforms. However, this
afternoon's CVS HEAD *does* pass the seg regression test for me on HPPA,
and I presume it passed on whatever Alvaro is using (btw, what was
that?). So there's definitely a platform dependency involved and not
just you-missed-a-pointer-someplace.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-04-18 22:18:56 | Re: float4/float8/int64 passed by value with tsearchfixup |
Previous Message | Gregory Stark | 2008-04-18 21:51:38 | Re: float4/float8/int64 passed by value with tsearchfixup |