Re: Ripping out pg_restore's attempts to parse SQL before sending it

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Ripping out pg_restore's attempts to parse SQL before sending it
Date: 2011-07-28 03:28:00
Message-ID: 24743.1311823680@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> While I've not yet done any excavation in the commit logs to confirm
> this, the nearby comments in the code indicate that separation of COPY
> data from SQL commands was adopted in archive format version 1.3, which
> is ancient. In fact, it's so ancient that there was never a production
> release of pg_dump that created pre-1.3 archives --- only 7.1devel
> versions ever produced those.

I've now poked around in the commit history, and found that pg_dump's
archive format, as well as pg_restore itself, were introduced in commit
500b62b05 of 2000-07-04. The 1.3 format revision was added in commit
e8f69be05 of 2000-07-21. So not only did the prior formats not get
written by any production releases, there was only an interval of a
couple of weeks where they'd even have been emitted by development HEAD.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2011-07-28 04:11:25 Re: patch for 9.2: enhanced errors
Previous Message Robert Haas 2011-07-28 02:51:49 cheaper snapshots