Re: GCC memory barriers are missing "cc" clobbers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: GCC memory barriers are missing "cc" clobbers
Date: 2014-09-19 14:58:56
Message-ID: 24722.1411138736@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-09-19 09:58:01 -0400, Tom Lane wrote:
>> While it might not be buggy as it stands, I think we should add the "cc"
>> rather than rely on it being implicit. One reason is that people will
>> look at the x86 cases when developing code for other architectures, and
>> they could easily forget to add "cc" on machines where it does matter.

> Fair point. It's also extremly poorly documented - my answer is from a
> gcc dev, I haven't found an official document stating it. I don't really
> see any need to backpatch though, do you?

Well, I'd make it the same in all branches which have that code, which
is not very far back is it?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-09-19 15:18:51 Re: GCC memory barriers are missing "cc" clobbers
Previous Message Andres Freund 2014-09-19 14:57:32 Re: GCC memory barriers are missing "cc" clobbers