Re: [bugfix] DISCARD ALL does not release advisory locks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Merlin Moncure" <mmoncure(at)gmail(dot)com>, "Marko Kreen" <markokr(at)gmail(dot)com>, "Postgres Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bugfix] DISCARD ALL does not release advisory locks
Date: 2008-11-26 20:45:51
Message-ID: 24710.1227732351@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com> writes:
> I kinda agree with you. The only problem IMHO is that we described in
> the doc exactly what it does and not simply as the big hammer it was
> supposed to be. See
> http://www.postgresql.org/docs/8.3/interactive/sql-discard.html .

Well, the *first* sentence there says it "resets the session to its
initial state", so it seems to me the intent is clear. But maybe we
should alter the second sentence to read, say, "This _currently_ has the
same effect as ...", thereby making it clear that this is implementation
detail and not the controlling definition.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2008-11-26 20:45:52 Re: [bugfix] DISCARD ALL does not release advisory locks
Previous Message Tom Lane 2008-11-26 20:42:47 Re: [bugfix] DISCARD ALL does not release advisory locks