From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: \crosstabview fixes |
Date: | 2016-04-13 20:41:47 |
Message-ID: | 24706.1460580107@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> (I also took the trouble to make the error messages conform
>> to project style.)
> Not sure about this part. Many psql error messages are full sentences (start
> with uppercase, end in period); others start with the \ command being
> complained about. Compare
> alvherre=# \foobar
> Invalid command \foobar. Try \? for help.
> alvherre=# \copy foobar
> \copy: parse error at end of line
Well, the first of those is meant to be two full sentences, though they
are a bit abbreviated.
I think putting "\crosstabview: " in front of all the error messages
in this patch would be a fine idea, though. Will do that unless there
are further objections.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2016-04-13 20:44:50 | Re: [patch] \crosstabview documentation |
Previous Message | Tom Lane | 2016-04-13 20:39:40 | Re: \crosstabview fixes |