dead code in wparser_def state machine?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: dead code in wparser_def state machine?
Date: 2007-10-23 17:40:39
Message-ID: 24632.1193161239@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I find a number of places coded like this:

static TParserStateActionItem actionTPS_InHyphenLatWordFirst[] = {
{p_isEOF, 0, A_POP, TPS_Null, 0, NULL},
{p_islatin, 0, A_NEXT, TPS_InHyphenLatWord, 0, NULL},
{p_isnonlatin, 0, A_NEXT, TPS_InHyphenUWord, 0, NULL},
{p_isdigit, 0, A_NEXT, TPS_InHyphenValue, 0, NULL},
{p_isdigit, 0, A_NEXT, TPS_InHyphenUWord, 0, NULL},
{NULL, 0, A_POP, TPS_Null, 0, NULL}
};

If I'm not completely misunderstanding this code, the second p_isdigit
line is dead code because it can never be reached. Correct?

regards, tom lane

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2007-10-23 17:47:39 Re: Feature Freeze date for 8.4
Previous Message Neil Conway 2007-10-23 17:24:20 Re: PostgreSQL performance issues