| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: COMMENT ON |
| Date: | 2001-09-11 15:50:31 |
| Message-ID: | 2457.1000223431@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> COMMENT ON AGGREGATE my_aggregate double precision IS 'Computes
>> sample variance';
>>
>> works but looks strange syntax. Should we fix the program or docs?
> I vote for fixing the program.
If we fix this, we should also change DROP AGGREGATE, which also uses
the paren-less syntax. (I think the COMMENT ON syntax was modeled on
DROP.)
I'd be in favor of changing, but we do need to maintain consistency.
Another issue is that pg_dump knows about using both of these
commands... we'll have a compatibility problem if we don't continue
to accept the old syntax for awhile.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Lockhart | 2001-09-11 16:14:03 | Re: factorial doc bug? |
| Previous Message | P. Dwayne Miller | 2001-09-11 15:39:49 | COPY command WITH NULLs bug? |