From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Disable alternate locations on Win32 |
Date: | 2003-05-07 04:11:56 |
Message-ID: | 24566.1052280716@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Why not do it with one ifdef in one place?
> I checked this again and the test is at the top, while the symlink()
> call is at the bottom after the database has already been copied. I
> think we do need to error out before we start copying the database.
Huh? We haven't copied anything at that point. We have done the
mkdir() though. On spec-compliant platforms it'd be possible to
switch the order of these operations, so that the symlink comes before
mkdir. Does anyone know of a platform on which symlink() fails if the
referenced pathname doesn't exist yet?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Matthew T. O'Connor | 2003-05-07 05:28:49 | pg_autovacuum update |
Previous Message | Bruce Momjian | 2003-05-07 03:51:32 | Re: Disable alternate locations on Win32 |