Re: pgsql: Add tests for reinit.c

I wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Add tests for reinit.c

> BTW, buildfarm member jacana hasn't succeeded at this test once.
> The failures look like

> ok 1 - init fork in base exists
> ok 2 - main fork in base exists
> error running SQL: 'psql:<stdin>:1: ERROR: directory "/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/tmp_test_wBGG" does not exist'
> while running 'psql -XAtq -d port=50531 host=127.0.0.1 dbname='postgres' -f - -v ON_ERROR_STOP=1' with sql 'CREATE TABLESPACE ts1 LOCATION '/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/tmp_test_wBGG'' at /home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/test/perl//PostgresNode.pm line 1246.

> so I hypothesize that there's something wrong with TestLib::tempdir on
> Windows, but no idea what.

After further staring at that, I think it's some sort of mingw path
weirdness. I notice that the initdb output refers to the PGDATA
directory as

c:/mingw/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/t_014_unlogged_reinit_main_data/pgdata

and then after that we see "pg_ctl start" succeeding with just

/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/t_014_unlogged_reinit_main_data/pgdata

but this isn't working:

/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/recovery/tmp_check/tmp_test_esA3

perhaps because it lacks the "c:/mingw/msys/1.0" prefix.

Still no opinion about how to fix it.

regards, tom lane