From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
---|---|
To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Claudio Freire <klaussfreire(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
Subject: | Re: [HACKERS] Block level parallel vacuum |
Date: | 2020-01-13 09:21:58 |
Message-ID: | 24557971578907318@sas1-55829ddbd171.qloud-c.yandex.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello
> I just thought they were concerned
> that the variable name skip_index might be confusing because we skip
> if skip_index is NOT true.
Right.
>> > - bool skip_index = (get_indstats(lps->lvshared, i) == NULL ||
>> > - skip_parallel_vacuum_index(Irel[i], lps->lvshared));
>> > + bool can_parallel = (get_indstats(lps->lvshared, i) == NULL ||
>> > + skip_parallel_vacuum_index(Irel[i],
>> > + lps->lvshared));
>> >
>> > The above condition is true when the index can *not* do parallel index vacuum.
Ouch, right. I was wrong. (or the variable name and the comment really confused me)
> Okay, would it better if we get rid of this variable and have code like below?
>
> /* Skip the indexes that can be processed by parallel workers */
> if ( !(get_indstats(lps->lvshared, i) == NULL ||
> skip_parallel_vacuum_index(Irel[i], lps->lvshared)))
> continue;
Complex condition... Not sure.
> How about changing it to skipped_index and change the comment to something like “We are interested in only index skipped parallel vacuum”?
I prefer this idea.
> Today, again thinking about it, it seems
> the idea Mahendra is suggesting that is giving an error if the
> parallel degree is not specified seems reasonable to me.
+1
regards, Sergei
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2020-01-13 09:25:05 | Re: How to make a OpExpr check compatible among different versions |
Previous Message | Krasiyan Andreev | 2020-01-13 09:17:02 | [PATCH] distinct aggregates within a window function WIP |