Re: pgsql: Fix bug in Tid scan.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix bug in Tid scan.
Date: 2020-02-08 01:04:30
Message-ID: 24554.1581123870@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> On Sat, Feb 8, 2020 at 4:25 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> AFAICS, this patch has caused an ABI break in v12. Do we really
>> believe that no extension references the values of the ScanOptions
>> enum?

> Yes, you are right. Some extensions may depend on it.
> It's better not to add new ScanOption not to break ABI.

I think it's okay to add a new value of ScanOption; what you can't
do is change the codes assigned to the existing values. So I'd
just revert those code changes and give SO_TYPE_TIDSCAN a value
that's out-of-order.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2020-02-08 02:01:59 Re: pgsql: Fix bug in Tid scan.
Previous Message Fujii Masao 2020-02-08 00:35:10 Re: pgsql: Fix bug in Tid scan.