Re: [COMMITTERS] pgsql: Have dtrace depend on object files directly, not objfiles.txt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Have dtrace depend on object files directly, not objfiles.txt
Date: 2015-10-15 17:01:59
Message-ID: 24541.1444928519@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Have dtrace depend on object files directly, not objfiles.txt

This patch appears to have broken parallel builds. I get this:

$ make -j8 -s
cat: access/objfiles.txt: No such file or directory
cat: bootstrap/objfiles.txt: No such file or directory
cat: catalog/objfiles.txt: No such file or directory
cat: parser/objfiles.txt: No such file or directory
cat: commands/objfiles.txt: No such file or directory
cat: executor/objfiles.txt: No such file or directory
... lots more omitted ...
cat: storage/objfiles.txt: No such file or directory
cat: tcop/objfiles.txt: No such file or directory
cat: tsearch/objfiles.txt: No such file or directory
cat: utils/objfiles.txt: No such file or directory
In file included from gram.y:14919:
scan.c: In function 'yy_try_NUL_trans':
scan.c:10307: warning: unused variable 'yyg'
All of PostgreSQL successfully made. Ready to install.

and this:

$ make -s clean
cat: ../../src/timezone/objfiles.txt: No such file or directory

despite the fact that I'm not using dtrace. I imagine this
comes from gmake trying to evaluate the dependencies for
utils/probes.o before all the subdirectories have been built.

Please fix or revert.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-10-15 17:14:37 pgsql: Allow FDWs to push down quals without breaking EvalPlanQual rech
Previous Message Alvaro Herrera 2015-10-15 15:21:19 pgsql: Fix bogus comments

Browse pgsql-hackers by date

  From Date Subject
Next Message Robbie Harwood 2015-10-15 17:07:51 Re: [PATCH v3] GSSAPI encryption support
Previous Message Alvaro Herrera 2015-10-15 16:22:36 Re: remaining open items