From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: dollar quoting |
Date: | 2004-02-07 21:51:02 |
Message-ID: | 24536.1076190662@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> After staring at the code for a long time, I think I see how to do this.
> It's complicated a bit by the fact that $ is a valid identifier
> character. So my current thinking is to say that if we see $ not in a
> quote and not preceded by a valid identifier char then it is the start
> of a $foo$ sequence. Or have I missed something? Can we validly see $ in
> any other context?
Right, a $ should be considered to start a quote marker only if it's not
part of an identifier. The backend lexer doesn't have a problem with
this because it's written in flex, but I can imagine that getting it
right in psql's ad-hoc parser might be tricky.
There was some discussion awhile back of converting psql to use flex
for interpreting its input, but I dunno how practical that really is.
I don't know how you get flex to do reasonable stuff with an incomplete
input string. Still, it might be worth looking into.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-02-08 00:45:18 | Re: PITR Dead horse? |
Previous Message | Diego Montenegro | 2004-02-07 21:11:03 | Backend Code |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-02-08 00:45:57 | Re: dollar quoting |
Previous Message | Joe Conway | 2004-02-07 20:19:48 | Re: dblink: rollback transaction |