| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org> |
| Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
| Subject: | Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid. |
| Date: | 2012-06-25 16:35:02 |
| Message-ID: | 24421.1340642102@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Remove sanity test in XRecOffIsValid.
> Commit 061e7efb1b4c5b8a5d02122b7780531b8d5bf23d changed the rules
> for splitting xlog records across pages, but neglected to update this
> test. It's possible that there's some better action here than just
> removing the test completely, but this at least appears to get some
> of the things that are currently broken (like initdb on MacOS X)
> working again.
Offhand, I'm wondering why this macro doesn't include a MAXALIGN test.
If it did, I don't think that the upper-limit test would have any
use anymore.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-06-25 17:12:54 | Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid. |
| Previous Message | Robert Haas | 2012-06-25 16:18:44 | pgsql: Remove sanity test in XRecOffIsValid. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2012-06-25 16:42:41 | Re: Catalog/Metadata consistency during changeset extraction from wal |
| Previous Message | Robert Haas | 2012-06-25 16:18:44 | pgsql: Remove sanity test in XRecOffIsValid. |