| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow wal_keep_segments to keep all segments |
| Date: | 2010-06-03 14:22:31 |
| Message-ID: | 24360.1275574951@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Heikki Linnakangas wrote:
>> Surely we don't expect DBAs to delete old files in pg_xlog? I agree with
>> Simon here, I think it would be better to not provide -1 as an option
>> here. At least you better document well that you should only do that
>> temporarily or you will eventually run out of disk space.
> I have updated the doc text to mention "temporarily" everywhere '-1' is
> mentioned.
FWIW, I've come to agree with Simon. Allowing -1 doesn't do anything
that you can't do with a large positive setting, and what it does do
is to encourage people to set the variable to an unsafe value as a
substitute for thinking.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2010-06-03 14:41:55 | Re: How to pass around collation information |
| Previous Message | Bruce Momjian | 2010-06-03 14:16:13 | Re: ALTER TABLE .... make constraint DEFERRABLE |