Re: Emacs vs pg_indent's weird indentation for function declarations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
Date: 2019-05-19 18:13:09
Message-ID: 2436.1558289589@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
> On 19/05/2019 19.27, Tom Lane wrote:
>> Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
>>> I think it's safe to assume that upstream can drop support for K&R-style
>>> parameters altogether.

>> Cool. I already created the switch, but maybe we could have it
>> default to -nkr?

> Sorry, but GNU indent already uses -kr for something else and I would
> like FreeBSD indent have something like that under the same name.
> Besides, indent has too many options and this one doesn't look like
> particularly desired by anyone. It's possible that someone will complain
> some day, but I don't think we should assume that they'll do or that
> they're more important than the other users who benefit from your change
> being the default behavior and no additional options.

Huh. OK, I'll rip the switch back out again.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-19 18:14:54 Re: Multivariate MCV stats can leak data to unprivileged users
Previous Message Piotr Stefaniak 2019-05-19 17:50:50 Re: Emacs vs pg_indent's weird indentation for function declarations