| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Marti Raudsepp <marti(at)juffo(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: [PATCH] Caching for stable expressions with constant arguments v3 |
| Date: | 2011-12-05 19:36:14 |
| Message-ID: | 2433.1323113774@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> On 05.12.2011 20:53, Marti Raudsepp wrote:
>> I considered stripping CacheExpr nodes later in PL/pgSQL, but I can't
>> remember right now why I rejected that approach (sorry, it's been 2
>> months).
> Yet another idea would be to leave the CacheExprs there, but provide a
> way to reset the caches. PL/pgSQL could then reset the caches between
> every invocation.
We're likely to need a way to reset these caches anyway, at some point...
> Or pass a flag to ExecInitExpr() to skip through the CacheExprs.
Not sure what you mean by that --- are you imagining that the ExprState
tree would have structure not matching the Expr tree? That seems just
about guaranteed to break something somewhere.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2011-12-05 19:42:19 | Re: [PATCH] Caching for stable expressions with constant arguments v3 |
| Previous Message | Tom Lane | 2011-12-05 19:30:40 | Re: planner fails on HEAD |