Re: Solaris testers wanted for strxfrm() behavior

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Mlodgenski <jimmy76(at)gmail(dot)com>
Subject: Re: Solaris testers wanted for strxfrm() behavior
Date: 2015-06-28 23:00:14
Message-ID: 24297.1435532414@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <pg(at)heroku(dot)com> writes:
> On Sun, Jun 28, 2015 at 12:58 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>> My perspective is that if both SmartOS and OmniOS pass, it's not our
>> responsibility to support OldSolaris if they won't update libraries.

> Obviously I especially don't want to double the number of strxfrm()
> calls made during text abbreviation for *everyone* just to work around
> this silly bug. Those calls will generally be a large fraction of the
> cost of any text sort in 9.5, so clearly that would be unacceptable.

I agree, but ...

> Maybe Noah should commit a patch that makes the initial size of the
> buffer that stores the transformed string blob very small. This can be
> reverted once it has some buildfarm cycles. That is a bit of a scatter
> gun approach, but maybe that's inevitable given the paucity of
> information around the issue.

Another idea would be to make a test during postmaster start to see
if this bug exists, and fail if so. I'm generally on board with the
thought that we don't need to work on systems with such a bad bug,
but it would be a good thing if the failure was clean and produced
a helpful error message, rather than looking like a Postgres bug.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-06-28 23:14:14 Re: Solaris testers wanted for strxfrm() behavior
Previous Message Tom Lane 2015-06-28 22:57:24 Re: Solaris testers wanted for strxfrm() behavior