Re: unchecked out of memory in postmaster.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unchecked out of memory in postmaster.c
Date: 2009-04-06 23:31:49
Message-ID: 24283.1239060709@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I think a patch to solve this is as simple as the attached.

I guess I need to point out that those ereport calls already pose a far
more substantial risk of palloc failure than the DLNewElem represents.

You seem to have forgotten about releasing the DLElem if the fork fails,
too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-04-06 23:44:23 Re: default parameters for built-in functions (was Re: Documentation Update: Document pg_start_backup checkpoint behavior)
Previous Message Alvaro Herrera 2009-04-06 23:28:56 Re: default parameters for built-in functions (was Re: Documentation Update: Document pg_start_backup checkpoint behavior)