Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Christoph Berg <myon(at)debian(dot)org>, Jason Petersen <jason(at)citusdata(dot)com>, pgsql-pkg-debian(at)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Date: 2017-05-30 16:47:20
Message-ID: 24279.1496162840@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-pkg-debian

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-05-29 15:45:11 -0400, Tom Lane wrote:
>> Maybe this is small enough to not be something we need to worry about,
>> but I'm wondering if we should ask citus and other large .so's to set
>> some additional make flag that would cue usage of -fPIC over -fpic.

> I think we can fix this easily enough in Citus, postgis, and whatever.
> But it's not a particularly good user/developer experience, and
> presumably is going to become more and more common. On x86 there
> shouldn't be a difference in efficiency between the two, but some others
> will see some. Given that most distributions switched to building the
> main executables with -fPIE anyway, to allow for ASLR, it seems unlikely
> that the intra extension overhead is going to be very meaningful in
> comparison.

Very possibly true, but I wish we had some hard facts and not just
guesses.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2017-05-30 16:52:58 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Previous Message Robert Haas 2017-05-30 16:45:43 Re: "cannot specify finite value after UNBOUNDED" ... uh, why?

Browse pgsql-pkg-debian by date

  From Date Subject
Next Message Christoph Berg 2017-05-30 16:52:58 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Previous Message Andres Freund 2017-05-30 16:15:41 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x