| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Make heap TID a tiebreaker nbtree index column. |
| Date: | 2019-03-20 20:46:50 |
| Message-ID: | 24277.1553114810@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Wed, Mar 20, 2019 at 11:30 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>> Your work on test stability probably eliminated 98% of the problems.
>> It's still early, but the buildfarm is mostly fine.
> batfish just had a similar failure, this time in foreign_data -- two
> lines of "DETAIL" output appear in opposite-of-expected order.
> Obviously that's unstable in a way that it wasn't before now, since
> every other animal doesn't have that problem.
Yeah. My opinion is that we should just qsort the list of targets
during DROP OWNED and be done with this. I'll post a patch shortly.
In the meantime, would you mind cleaning this up:
nbtxlog.c: In function 'btree_xlog_split':
nbtxlog.c:269: warning: 'newitem' may be used uninitialized in this function
nbtxlog.c:269: note: 'newitem' was declared here
nbtxlog.c:271: warning: 'newitemsz' may be used uninitialized in this function
nbtxlog.c:271: note: 'newitemsz' was declared here
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-03-20 20:47:41 | Re: pgsql: Make heap TID a tiebreaker nbtree index column. |
| Previous Message | Peter Geoghegan | 2019-03-20 20:41:14 | pgsql: Suppress DETAIL output from a foreign_data test. |