| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unused parameters & co in code |
| Date: | 2019-01-31 09:15:21 |
| Message-ID: | 24267.1548926121@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Hi all,
>
> I just got a run with CFLAGS with the following options:
> -Wunused-function -Wunused-variable -Wunused-const-variable
> -Wno-unused-result -Wunused-parameter -Wunused-macros
>
> And while this generates a lot of noise for callbacks and depending on
> the environment used, this is also pointing to things which could be
> simplified:
This reminds me that I reported some unused arguments too:
https://www.postgresql.org/message-id/6702.1473067599@localhost
SnapBuildBuildSnapshot() was fixed in commit 6c2003f8a1b, but the other two
are still there.
--
Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26, A-2700 Wiener Neustadt
Web: https://www.cybertec-postgresql.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Khandekar | 2019-01-31 10:07:45 | Re: Pluggable Storage - Andres's take |
| Previous Message | Iwata, Aya | 2019-01-31 09:11:06 | RE: libpq debug log |