Re: [PATCH] New [relation] option engine

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: jian he <jian(dot)universality(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Subject: Re: [PATCH] New [relation] option engine
Date: 2024-06-22 18:21:08
Message-ID: 24214970.ouqheUzb2q@thinkpad-pgpro
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While fixing the patch according to jian he recommendations, I come to a
conclusion that using void* pointer to a structure is really bad idea. Do not
know why I ever did it that way from start.
So I fixed it.
Changes of this fix can be seen here:
https://gitlab.com/dhyannataraj/postgres/-/commit/be4d9e16

The whole patch is attached to this mail.

--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

Attachment Content-Type Size
v9-0001-New-options-engine.patch text/x-patch 205.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-06-22 20:42:47 Re: allow changing autovacuum_max_workers without restarting
Previous Message David E. Wheeler 2024-06-22 18:10:00 Re: Inconsistent Parsing of Offsets with Seconds