Re: syslogger line-end processing infelicity

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: syslogger line-end processing infelicity
Date: 2007-06-01 21:33:31
Message-ID: 24146.1180733611@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I have been looking at the syslogger code in connection with the CSV log
> output proposal, and I'm quite concerned about the way it translates
> every \n into \r\n for Windows output.
> ...
> My second thought is that we should quite possibly abandon this
> translation altogether

+1 on that. The problem of ensuring atomic output remains though
(see nearby complaints from George Pavlov and others). It's bad enough
in the existing logging context, but if we're hoping to make
easily-machine-readable logs it's a "must fix".

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-06-01 21:36:13 Re: query log corrupted-looking entries
Previous Message Bruce Momjian 2007-06-01 21:31:52 Upcoming events