| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY |
| Date: | 2009-08-10 20:31:55 |
| Message-ID: | 24084.1249936315@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Robert Haas escribi:
>>> The code in the new block was not reindented; it will be fixed by pgindent
>>> eventually.
>>
>> ...breaking every patch that someone has in progress against that code?
> I guess I neglected to add "a year from now or so". I'm not in a hurry
> to run pgindent.
Yeah --- if there are any active patches against that code (a fact not
in evidence) then reindenting now would break them now. Leaving it till
the next pgindent run seems fine to me.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-08-10 21:39:30 | Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY |
| Previous Message | Robert Haas | 2009-08-10 20:31:43 | Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-08-10 20:48:43 | Re: [HACKERS] BUG #4961: pg_standby.exe crashes with no args |
| Previous Message | Robert Haas | 2009-08-10 20:31:43 | Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY |