Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber
Date: 2021-10-21 14:46:14
Message-ID: 2407667.1634827574@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Japin Li <japinli(at)hotmail(dot)com> writes:
> On Thu, 21 Oct 2021 at 19:54, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> BTW I think we can set the parameters from the subscriber side without
>> additional network round trips by specifying the "options" parameter
>> in the connection string, no?

> Yes, we can. However, each client should be concerned the style for
> datestyle, IMO it is boring.

There's another issue here: the subscriber can run user-defined code
(in triggers), while AFAIK the sender cannot. People might be surprised
if their triggers run with a datestyle setting different from the
database's prevailing setting. So while I think it should be okay
to set-and-forget the datestyle on the sender side, we could not get
away with that in the subscriber. We'd have to set and unset for
each row, much as (e.g.) postgres_fdw has to do.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-10-21 14:53:58 Re: Assorted improvements in pg_dump
Previous Message Justin Pryzby 2021-10-21 14:28:52 Re: Assorted improvements in pg_dump