Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-10-11 17:11:47 -0400, Tom Lane wrote:
>> A compromise that occurred to me after a bit of reflection is to place
>> the necessary table-drop commands in a new regression test script that's
>> meant to be executed last, but isn't actually run by default. Then
>> teach the cross-version-update test script to include that script via
>> EXTRA_TESTS. Manual testing could do likewise. Then we have a small
>> amount of pain for testing upgrades, but we lose no test coverage in
>> back branches.

> To me that seems to be more work / infrastructure than
> warranted. abstime/reltime/tinterval don't present pg_dump with any
> special challenges compared to a lot of other types we do test, no?

Well, in any case I'd say we should put the dropping commands into
a separate late-stage test script. Whether that's run by default is a
secondary issue: if it is, somebody who wanted to test this stuff could
remove the script from their test schedule file.

regards, tom lane