| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: allow running parts of src/tools/msvc/ under not Windows |
| Date: | 2020-02-13 15:36:15 |
| Message-ID: | 24036.1581608175@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Thu, Feb 13, 2020 at 02:24:43PM +0100, Peter Eisentraut wrote:
>>> When making build system changes that risk breaking the MSVC build system,
>>> it's useful to be able to run the part of the MSVC build tools that read the
>>> makefiles and produce the project files under a not-Windows platform.
> With v2 I'm able to successfully run mkvcbuild.pl on linux and macos. I don't
> have any knowledge on compiling with windows, so I can't really judge what it's
> been doing.
Yeah, I'm wondering exactly how this helps. IME the typical sort of
breakage is "the MSVC build doesn't know that file X needs to be
included when building Y". It seems like just building the project
files will teach one nothing about that type of omission.
I don't have any particular objection to the patch as given, it
just doesn't sound helpful for me.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-02-13 15:47:54 | Re: Getting rid of some more lseek() calls |
| Previous Message | Ashutosh Bapat | 2020-02-13 15:35:01 | Re: LOCK TABLE and DROP TABLE on temp tables of other sessions |