Re: pgsql: Remove bogus dependencies on NUMERIC_MAX_PRECISION.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove bogus dependencies on NUMERIC_MAX_PRECISION.
Date: 2016-08-16 20:03:04
Message-ID: 24036.1471377784@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 8/14/16 3:06 PM, Tom Lane wrote:
>> Remove bogus dependencies on NUMERIC_MAX_PRECISION.

> Some compilers are reporting a warning

> dbsize.c:768:3: warning: ignoring return value of strtol, declared
> with attribute warn_unused_result [-Wunused-result]

Oh fchrissakes. Do they think it's a security problem, or any kind of
problem at all, if you only use the endptr result?

I guess we'll need the same sort of convoluted dance we use to shut up
this warning elsewhere. Will deal with it.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-08-16 20:14:24 pgsql: Suppress -Wunused-result warning for strtol().
Previous Message Tom Lane 2016-08-16 19:59:01 pgsql: Fix assorted places in psql to print version numbers >= 10 in ne