Re: pgsql: Multirange datatypes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Multirange datatypes
Date: 2020-12-30 19:32:09
Message-ID: 2400626.1609356729@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> On Wed, Dec 30, 2020 at 4:11 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Multiple buildfarm members are issuing similar warnings about
>> multirangetypes.c:
>> calliphoridae | 2020-12-29 23:10:11 | /home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/multirangetypes.c:218:37: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
>> calliphoridae | 2020-12-29 23:10:11 | /home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/multirangetypes.c:236:37: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]

> Thank you for noticing. I've slightly refactored this function in 16d531a30a.

Looks good, thanks!

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-12-30 22:49:08 pgsql: Doc: spell out comparison behaviors for the date/time types.
Previous Message Tom Lane 2020-12-30 19:16:02 pgsql: More fixups for pg_upgrade cross-version tests.