Re: Improper use about DatumGetInt32

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improper use about DatumGetInt32
Date: 2021-01-19 10:05:45
Message-ID: 23ce30da-193e-8dbc-c129-14533e45782b@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-01-14 09:00, Michael Paquier wrote:
> I don't have more comments by reading the code and my tests have
> passed after applying the patch on top of df10ac62. I would have also
> added some tests that check after blkno < 0 and > MaxBlockNumber in
> all the functions where it can be triggered as that's cheap for 1.8
> and 1.9, but that it's a minor point.

committed with some additional tests

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2021-01-19 10:28:42 Re: configurable the threshold for warning due to run out of transaction ID
Previous Message Dilip Kumar 2021-01-19 09:53:55 Re: [HACKERS] Custom compression methods