Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <pchampion(at)pivotal(dot)io>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that
Date: 2018-08-07 17:17:12
Message-ID: 23879.1533662232@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jacob Champion <pchampion(at)pivotal(dot)io> writes:
> On Mon, Aug 6, 2018 at 12:45 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Ah, gotcha. But whether the behavior is sane or not, it'd be reproducible
>> for any specific input dataset on any specific platform (unless you've got
>> a quicksort that actually uses randomized pivots; but ours doesn't, and
>> I think that pg_dump does use src/port/qsort.c). So that partially
>> answers Andrew's question as to why we've not seen instability in the
>> buildfarm's results.

> I completely missed that the qsort in use was part of libpgport; that
> should make it much easier to repro. We'll give it a shot.

I don't see any reason to insist on a test case before pushing this
fix, so I did that. (As I expected, the fix doesn't change any existing
regression test results.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-07 17:32:42 Re: [PATCH] Include application_name in "connection authorized" log message
Previous Message Don Seiler 2018-08-07 16:57:11 Re: [PATCH] Include application_name in "connection authorized" log message