Re: bug in PG_VERSION_NUM patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: bug in PG_VERSION_NUM patch
Date: 2006-02-28 22:29:08
Message-ID: 2385.1141165748@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> OK, I reread the manual page:

> As each input record is read, gawk splits the record into
> fields, using the value of the FS variable as the field
> separator. If FS is a single character, fields are sepa-
> rated by that character. If FS is the null string, then
> each individual character becomes a separate field. Oth-
> erwise, FS is expected to be a full regular expression.

Hpmh. The HPUX man page for plain awk says

-F fs Specify regular expression used to separate
fields. The default is to recognize space and tab
characters, and to discard leading spaces and
tabs. If the -F option is used, leading input
field separators are no longer discarded.

which makes me think we are treading on mighty thin ice here --- there
are lots of different versions of awk around, and some of them are
probably going to treat -F '.' as a regexp.

I'd suggest splitting the input with something more standardized.
Perhaps

sed 's/\./ /g' | $AWK '{printf ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-02-28 22:33:45 Re: bug in PG_VERSION_NUM patch
Previous Message Hannu Krosing 2006-02-28 22:10:52 Re: Automatic free space map filling