Re: Add ENCODING option to COPY

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add ENCODING option to COPY
Date: 2011-02-04 16:30:30
Message-ID: 23844.1296837030@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
> 2011/2/5 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> The reason that we use quotes in CREATE DATABASE is that encoding names
>> aren't assumed to be valid SQL identifiers. If this patch isn't
>> following the CREATE DATABASE precedent, it's the patch that's wrong,
>> not CREATE DATABASE.

> What about SET client_encoding TO encoding?

SET is in its own little world --- it will interchangeably take names
with or without quotes. It is not a precedent to follow elsewhere.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hitoshi Harada 2011-02-04 16:41:45 Re: Add ENCODING option to COPY
Previous Message Hitoshi Harada 2011-02-04 16:26:58 Re: Add ENCODING option to COPY