| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade should truncate/remove its logs before running |
| Date: | 2021-12-22 14:52:26 |
| Message-ID: | 238201.1640184746@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Dec 20, 2021 at 09:39:26PM -0600, Justin Pryzby wrote:
>> Are you suggesting to remove these ?
>> -/pg_upgrade_internal.log
>> -/loadable_libraries.txt
> Yep, it looks so as these are part of the logs, the second one being a
> failure state.
>> -/reindex_hash.sql
> But this one is not, no?
I'd like to get to a state where there's just one thing to "rm -rf"
to clean up after any pg_upgrade run. If we continue to leave the
we-suggest-you-run-these scripts loose in $CWD then we've not really
improved things much.
Perhaps there'd be merit in putting log files into an additional
subdirectory of that output directory, like
pg_upgrade_output.d/logs/foo.log, so that the more-ignorable
output files would be separated from the less-ignorable ones.
Or perhaps that's just gilding the lily.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-12-22 15:07:49 | Re: do only critical work during single-user vacuum? |
| Previous Message | Pavel Stehule | 2021-12-22 14:37:18 | Re: [Proposal][WIP] Add option to log auto_explain output to separate logfile |