| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Marko Kreen <markokr(at)gmail(dot)com> |
| Cc: | Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [patch] libpq one-row-at-a-time API |
| Date: | 2012-07-16 13:33:39 |
| Message-ID: | 23653.1342445619@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Marko Kreen <markokr(at)gmail(dot)com> writes:
> On Mon, Jul 16, 2012 at 4:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm starting to look at this patch now. I think we could drop the
>> PQgetRowData() API: it complicates matters for little gain that I can
>> see. The argument for it was to avoid the cost of creating a PGresult
>> per row, but we're already going to pay the cost of creating a
>> PGresult in order to return the PGRES_SINGLE_TUPLE status.
> No. Please look again, it is supposed to be called instead of PGgetResult().
Mm. I still think we should drop it, because it's still a dangerous API
that's not necessary for the principal benefit of this feature.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-07-16 15:24:37 | Re: CompactCheckpointerRequestQueue versus pad bytes |
| Previous Message | Marko Kreen | 2012-07-16 10:27:12 | Re: [patch] libpq one-row-at-a-time API |