Re: How does MSVC's fetchRegressOpts() work at all?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: How does MSVC's fetchRegressOpts() work at all?
Date: 2015-05-18 17:28:33
Message-ID: 23571.1431970113@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 05/18/2015 12:48 PM, Tom Lane wrote:
>> Looking at vcregress.pl's sub fetchRegressOpts, it seems that it only
>> notices "REGRESS_OPTS =" lines not "REGRESS_OPTS +=" lines, so that
>> isn't surprising --- but how is it that the tests *are* still loading
>> plpythonu and hstore_plpythonu? I grant that my Perl is weak, but
>> I don't see how this code would ever have dealt with either lines
>> using +=, or multiple assignments to REGRESS_OPTS. How come it worked
>> before?

> relevant code:

Oh man, that's ugly.

If I were to fix fetchRegressOpts so it picks up all the makefile's
additions to REGRESS_OPTS, would we be able to eliminate that hack?
Or do we need the python-version kluge anyway?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-05-18 17:29:36 Re: Making the regression tests halt to attach a debugger
Previous Message Andres Freund 2015-05-18 17:21:47 Re: ERROR: cannot GetMultiXactIdMembers() during recovery