| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tristan Partin <tristan(at)neon(dot)tech>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add BF member koel-like indentation checks to SanityCheck CI |
| Date: | 2024-01-10 06:25:36 |
| Message-ID: | 2346904.1704867936@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> Off the top of my head, I like to use '//' comments as quick notes to
> myself that stand out from normal code comments, and I'm in the habit
> of putting debug print statements flush against the left margin so
> they're really obvious. Both of these would be wiped out by pgindent.
+1. I do both of those things, partly because pgindent would reformat
them so that it'd be obvious if I forgot to remove them. (Yes, I
look at the diffs pgindent wants to make...)
So that leads to the conclusion that I wouldn't want an automatic
pgindent check to happen during "make all" or "make check", because
I want those things to succeed before I consider pgindent'ing.
Maybe it's okay to include it as part of check-world, but I'm
not quite sure about that either.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2024-01-10 06:26:08 | Re: Synchronizing slots from primary to standby |
| Previous Message | Sutou Kouhei | 2024-01-10 06:20:23 | Re: Make COPY format extendable: Extract COPY TO format implementations |