Re: how to run encoding-dependent tests by default

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: how to run encoding-dependent tests by default
Date: 2019-07-29 14:47:25
Message-ID: 23424.1564411645@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2019-07-28 20:12, Tom Lane wrote:
>> So I wish we could get rid of the Makefile changes, have the test
>> scripts be completely responsible for whether to run themselves or
>> not, and put them into the schedule files normally.

> Good points. Updated patch attach.

v3 looks good and passes local testing. I've marked it RFC.

> (The two tests create the same schema name, so they cannot be run in
> parallel. I opted against changing that here, since it would blow up
> the patch and increase the diff between the two tests.)

This does create one tiny nit, which is that the order of the
parallel and serial schedule files don't match. Possibly I'm
overly anal-retentive about that, but I think it's confusing
when they don't.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2019-07-29 14:53:36 Re: Define jsonpath functions as stable
Previous Message Tom Lane 2019-07-29 14:36:31 Re: Define jsonpath functions as stable