Re: strange error reporting

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: strange error reporting
Date: 2021-01-26 21:45:23
Message-ID: 2338295.1611697523@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> pgbench has one occurrence of the old pattern in master, in line 6043.
> However, since doConnect() returns NULL when it gets CONNECTION_BAD,
> that seems dead code. This patch kills it.

Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams
call :-(. You're right, that's dead code and we should just delete it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-01-26 21:55:15 wiki:PostgreSQL_14_Open_Items
Previous Message Tom Lane 2021-01-26 21:39:19 Re: 13dev failed assert: comparetup_index_btree(): ItemPointer values should never be equal