Re: Hash id in pg_stat_statements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hash id in pg_stat_statements
Date: 2012-10-01 14:10:12
Message-ID: 23336.1349100612@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Can we please expose the internal hash id of the statements in
> pg_stat_statements?

> I know there was discussions about it earlier, and it wasn't done with
> an argument of it not being stable between releases (IIRC).

Worse than that: it could change across a minor version update. These
are internal data structures we're hashing, and we've been known to
have to change them for bug-fix purposes.

> I've now run into multiple customer installations where it would be
> very useful to have. The usecase is mainly storing snapshots of the
> pg_stat_statements output over time and analyzing those.

Doesn't that immediately refute your claim that unstable hash values
would be okay?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-10-01 14:12:06 Re: Oid registry
Previous Message Tom Lane 2012-10-01 14:07:01 Re: CTE optimization fence on the todo list?