Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.
Date: 2014-02-02 00:14:23
Message-ID: 23314.1391300063@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Copy the libpq DLL to the bin directory on Mingw and Cygwin.

AFAICT, this patch set is completely broken.

The buildfarm shows that every build attempt on the 8.4 branch has
failed since it went in. This is because MKDIR_P isn't defined in
that branch; you need to use $(mkinstalldirs) instead. However,
the bigger problem is the fact that non-Windows platforms are even
reaching that code; apparently, your if-logic is wrong. Testing
shows that libpq.so is getting installed into the bindir in HEAD
on my quite definitely not Windows system.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2014-02-02 00:24:04 Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.
Previous Message Tom Lane 2014-02-01 23:28:10 pgsql: Fix some wide-character bugs in the text-search parser.