| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Subject: | Re: compiler warning with VS 2017 |
| Date: | 2017-05-05 14:56:40 |
| Message-ID: | 2326.1493996200@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> On 05/05/17 06:50, Tom Lane wrote:
>> Actually, looking around a bit there, it's not even clear why
>> we should be booby-trapping the value of an unchanged column in
>> the first place. So I'd say that not only is the code dubious
>> but the comment is inadequate too.
> Hmm, as far as I can recollect this is just leftover debugging code that
> was intended to help ensure that we are checking the "changed"
> everywhere we are supposed to (since I changed handling of these
> structured quite a bit during development). Should be changed to NULL,
> that's what we usually do in this type of situation.
So the comment should be something like "if the column is unchanged,
we should not attempt to access its value beyond this point. To
help catch any such attempts, set the string to NULL" ?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-05-05 14:58:12 | Re: compiler warning with VS 2017 |
| Previous Message | Peter Eisentraut | 2017-05-05 14:50:11 | Re: logical replication and PANIC during shutdown checkpoint in publisher |