| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Sam Mason <sam(at)samason(dot)me(dot)uk> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: NaN support in NUMERIC data type |
| Date: | 2009-04-08 22:11:59 |
| Message-ID: | 23231.1239228719@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sam Mason <sam(at)samason(dot)me(dot)uk> writes:
> On Tue, Apr 07, 2009 at 12:51:21PM -0400, Tom Lane wrote:
>> IIRC, the explicit support for leading/trailing spaces is something that
>> we added in float8in long after numeric_in was written, and I think just
>> nobody thought about numeric at the time. But it's clearly inconsistent
>> to allow spaces around a regular value but not a NaN.
> The included patch was generated against 8.3.5 (because that's what I
> had lying around when I started playing) but applies with a little fuzz
> to the latest snapshot and does the right thing for me in both versions.
Hmm, did it do the right thing for NaN with a typmod? I doubt
apply_typmod is safe for a NaN. Anyway, I revised this a bit and
applied to HEAD. I'm disinclined to back-patch; it's not really a bug
but a definition change, and we get flack when we put that sort of
change into stable branches ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-04-08 22:29:53 | Re: psql \d commands and information_schema |
| Previous Message | Bruce Momjian | 2009-04-08 22:03:31 | GUC inconsistency in 8.4? |