Re: Should libpq set close-on-exec flag on its socket?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dennis Bjorklund <db(at)zigo(dot)dhs(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should libpq set close-on-exec flag on its socket?
Date: 2004-10-21 19:53:19
Message-ID: 23213.1098388399@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dennis Bjorklund <db(at)zigo(dot)dhs(dot)org> writes:
> On Thu, 21 Oct 2004, Tom Lane wrote:
>> It was suggested to me off-list that libpq should do
>> "fcntl(fd, F_SETFD, FD_CLOEXEC)" on the socket connecting to the server.
>> This would prevent any child program from accidentally or maliciously
>> interfering with the connection.

> Either way that the lib sets it, the client can alter the setting itself
> by issuing a new SETFD command.

That's a fair point, and certainly passing it down to the child
intentionally wouldn't be a common case. I'll put the change in.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim C. Nasby 2004-10-21 20:17:25 Re: plans for bitmap indexes?
Previous Message Dennis Bjorklund 2004-10-21 19:07:44 Re: Should libpq set close-on-exec flag on its socket?