| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Make pg_stop_backup() archive wait optional |
| Date: | 2017-03-22 21:34:40 |
| Message-ID: | 22d564fc-545f-d242-fef1-b33dac9ac1f6@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/22/17 4:42 PM, Peter Eisentraut wrote:
> On 3/22/17 15:14, Stephen Frost wrote:
>>> -SELECT * FROM pg_stop_backup(false);
>>> +SELECT * FROM pg_stop_backup(false [, true ]);
>>>
>>> I think that it's better to get rid of "[" and "]" from the above because
>>> IMO this should be the command example that users actually can run.
>> Using the '[' and ']' are how all of the optional arguments are
>> specified in the documentation, see things like current_setting() in our
>> existing documentation:
>
> In the synopsis, but not in concrete examples.
Wasn't quite sure what the protocol was in this case, and figured it was
easier to subtract than to add.
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2017-03-22 22:05:16 | Re: increasing the default WAL segment size |
| Previous Message | David Steele | 2017-03-22 21:33:37 | Re: increasing the default WAL segment size |