| From: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: COPY FROM crash |
| Date: | 2024-07-30 07:06:01 |
| Message-ID: | 22b33563-fe81-47f2-bd9f-e19db697a1da@Spark |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Zhang Mingli
www.hashdata.xyz
On Jul 30, 2024 at 13:35 +0800, David Rowley <dgrowleyml(at)gmail(dot)com>, wrote:
>
> If you're only able
> to get it to misbehave by setting MAX_PARTITION_BUFFERS to less than
> 2, then my suggested fix would be to add a comment to say that values
> less than to are not supported.
Right.
On Postgres this crash could only happen if it is set to zero.
I’ve updated the comments in patch v1 with an additional Assert.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-comments-for-MAX_PARTITION_BUFFERS-to-avoid-misb.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2024-07-30 07:07:10 | Re: COPY FROM crash |
| Previous Message | Li, Yong | 2024-07-30 06:48:26 | Re: Separate HEAP WAL replay logic into its own file |