From: | "Rady, Doug" <radydoug(at)amazon(dot)com> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |
Date: | 2018-03-26 20:23:48 |
Message-ID: | 22D7FB26-058A-4022-A94C-FFDAD9F97764@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3/25/18, 04:00, "Fabien COELHO" <coelho(at)cri(dot)ensmp(dot)fr> wrote:
Hello Fabien,
Hello Doug,
> Updated the patch to not do the #undef
> pgbench11-ppoll-v11.patch attached.
Patch applies. Do not forget to regenerate configure to test...
I've compiled and run with both ppoll & select options without issues.
Two quite minor style comment (at least 2 instances):
if (cond) return false; else return true;
ISTM that the simpler the better:
return !cond;
Fixed.
Also ISTM that the following does not comply with pg C style expectations
(idem, 2 instances):
} else {
Fixed.
Also fixed issue with 'timeout' not being passed as NULL when no timeout time.
--
Fabien.
Thanks!
doug
Attachment | Content-Type | Size |
---|---|---|
pgbench11-ppoll-v12.patch | application/octet-stream | 10.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-03-26 20:27:47 | Re: Parallel Aggregates for string_agg and array_agg |
Previous Message | Andres Freund | 2018-03-26 20:16:41 | Re: Why does load_external_function() return PGFunction? |