Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Cold welcoming message when installing anything because of LLVM bitcode stuff
Date: 2018-04-28 18:05:15
Message-ID: 22982.1524938715@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> JIT is introducing the installation of LLVM bitcode modules, and any
> installation done results in the following comment in output, which
> repeats basically for all the extensions installed:
> # Then install files
> #
> # The many INSTALL_DATA invocations aren't particularly fast, it'd be
> # good if we could coalesce them, but I didn't find a good way.

> Andres, could it be possible to move at least that block of comments in
> a place where this is not user-visible?

Agreed, there shouldn't be comments in the emitted shell commands;
I'm a bit surprised that works at all. Close inspection of the
"make install" output revealed a few other issues, which I hope
I fixed rather than making things worse.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-04-28 18:14:59 Re: Cold welcoming message when installing anything because of LLVM bitcode stuff
Previous Message Teodor Sigaev 2018-04-28 17:31:18 Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)